maybe fix crash in PDF files with jpx images by making opj_secret thr…

…ead-local
sumatrapdfreader · Sep 10, 2024 · e31eef3 · e31eef3
1 parent beec851
commit e31eef3
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/mupdf/source/fitz/load-jpx.c b/mupdf/source/fitz/load-jpx.c
@@ -99,7 +99,10 @@ typedef struct
  * threading systems.
  */
 
-static fz_context *opj_secret = NULL;
+/* SumatraPDF: opening multiple PDF files with jpx imags will crash because different
+ * threads will clobber opj_secret. Locking is not good enough
+*/
+__declspec(thread) static fz_context *opj_secret = NULL;
 
 static void set_opj_context(fz_context *ctx)
 {