Skip to content

Commit

Permalink
tweak corrupted installation docs
Browse files Browse the repository at this point in the history
  • Loading branch information
kjk committed Aug 31, 2024
1 parent 01e93fe commit 839dc4b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 1 addition & 3 deletions docs/md/Corrupted-installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ SumatraPDF comes in two flavors: a portable version and an installer.

A portable version is a self-contained executable and cannot be corrupted.

An installer needs to be run to be properly installed. Part of it is extracting `libmupdf.dll` library needed by installable flavor.

You cannot just rename the installer and run it.
An installer needs to be run to be properly installed. Part of it is extracting `libmupdf.dll` library.

There are 2 possible problem:

Expand Down
3 changes: 1 addition & 2 deletions src/SumatraStartup.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -691,8 +691,7 @@ static bool ForceRunningAsInstaller() {
return false;
}

TempStr exePath = GetSelfExePathTemp();
TempStr dir = path::GetDirTemp(exePath);
TempStr dir = GetSelfExeDirTemp();
TempStr path = path::JoinTemp(dir, "libmupdf.dll");
auto realSize = file::GetSize(path);
if (realSize < 0) {
Expand Down

0 comments on commit 839dc4b

Please sign in to comment.