Fix dual time restarts with UNST_CFL_NUMBER != 0 #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcarruscag
commented
Apr 28, 2021
Comment on lines
+2883
to
+2886
| else if (!option_name.compare("UNST_RESTART_ITER")) | ||
| newString.append("UNST_RESTART_ITER is deprecated. Use RESTART_ITER instead.\n\n"); | ||
| else if (!option_name.compare("DYN_RESTART_ITER")) | ||
| newString.append("DYN_RESTART_ITER is deprecated. Use RESTART_ITER instead.\n\n"); |
There was a problem hiding this comment.
Another two obsolete options.
|
|
||
| if ((dual_time) && (Iteration == 0) && (config->GetUnst_CFL() != 0.0) && (iMesh == MESH_0)) { | ||
| if (dual_time && (Iteration == config->GetRestart_Iter()) && (config->GetUnst_CFL() != 0.0) && (iMesh == MESH_0)) { |
There was a problem hiding this comment.
This is the fix, the rest was cleanup.
…/SU2 into fix_auto_dt_with_restart
TobiKattmann
approved these changes
Apr 28, 2021
Comment on lines
+9772
to
+9773
| fluid_zone |= config_container[iZone]->GetFluidProblem(); | ||
| structural_zone |= config_container[iZone]->GetStructuralProblem(); |
There was a problem hiding this comment.
For anyone wondering |= is a bitwise or operation and in this case for booleans this a |= b is equivalent to a = a || b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix this issue https://www.cfd-online.com/Forums/su2/235718-unsteady-2nd-order-dual-time-step-diverges-when-restarted-steady-solution.html
Plus other cleanups