Update guide for Vue to match current requirements #4825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-nk
changed the title
npm install to match current requirementsnpm install part to match current requirements
y-nk
changed the title
npm install part to match current requirements
igor-dv
added
the
patch:yes
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Nov 25, 2018
Update guide for Vue to match current requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
docs is not up to date regarding Guide for Vue.
What I did
Fixing the doc, added dependencies as they should be. It is separated in 2 parts to highlight dev and peer dependencies.
It will answer to #4505 #4475 and #4821
Side note
As @igor-dv mentioned on Discord,
babel-preset-vueis probably not necessary. As seen in this package's homepage, it's a preset to transform JSX in Vue projects, but Vue.js team advices to use template instead for the majority of cases (see here). As we can extend webpack configuration to add loaders easily, it would make more sense to removebabel-preset-vuefrom the dependencies and advice advanced users of Vue.js to add it themselves following existing SB documentation.