-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Replace inquirer with prompts #13225
Conversation
The value is false, so could also argue it should just be removed.
Awesome @thebuilder! I'll merge this next week as part of 6.2-alpha. This week I'm doing hotfixes to 6.1.x and freely merging back and forth between |
Are the failing build an issue? 🙂 It's a bit overwhelming trying to understand what causes error, when it happens right after checkout. |
@thebuilder our CI is completely borked at the moment. we're working with Circle CI to try to get it back in order. but you should only look at the required checks anyway. So |
@thebuilder Looks like there's a TS error that's breaking CI. Can you fix it?
6.2's in alpha now so otherwise ready to test & merge. |
# Conflicts: # lib/core/package.json # yarn.lock
@shilman Sorry about - Not sure how I could miss that. Editor might have been overloaded with types. 🙈 |
@thebuilder it looks like |
Issue: #13226
What I did
Replaced all instances of /~https://github.com/SBoudrias/Inquirer.js with /~https://github.com/terkelg/prompts
This is inspired by facebook/create-react-app#10083
They are mostly interchangeable, altho the "separator" option is missing from prompts. It can be emulated by using the "disabled" option, to prevent an item from being selected.
Based on the usage pattern, I opted for a some changes to how the prompts are presented.
bootstrap
This still uses a separator.
test
Splits the choice in to two different questions.
build
Prompts you upfront if this is a watch mode or not, before presenting the list of packages.
Packages can also be selected using autocomplete.
How to test
Run the commands relying on inquirere locally.