fix(xadd): Accept odd number of parameters (#1111)

stipsan · Jan 21, 2022 · b6805ed · b6805ed
1 parent 04fcbca
commit b6805ed
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/src/commands/xadd.js b/src/commands/xadd.js
@@ -1,5 +1,10 @@
 export function xadd(stream, id, ...args) {
-  if (!stream || !id || args.length === 0 || args.length % 2 !== 0) {
+  if (
+    !stream ||
+    !id ||
+    args.length === 0 ||
+    (args.includes('~') ? args.length < 4 : args.length % 2 !== 0)
+  ) {
     throw new Error("ERR wrong number of arguments for 'xadd' command");
   }
   if (!this.data.has(stream)) {

diff --git a/test/commands/xadd.js b/test/commands/xadd.js
@@ -22,6 +22,28 @@ describe('xadd', () => {
         expect(redis.data.get(`stream:stream:${id}`)).toEqual({
           polled: false,
         });
+      })
+      .then(() =>
+        redis.xadd(
+          'stream',
+          'MAXLEN',
+          '~',
+          '50',
+          '*',
+          'reading',
+          '{"key": "value"}'
+        )
+      )
+      .then((id) => {
+        expect(id).toBe('MAXLEN-0');
+        expect(redis.data.get('stream')).toEqual([
+          ['1-0', ['key', 'val']],
+          ['2-0', ['key', 'val']],
+          ['MAXLEN-0', ['~', '50', '*', 'reading', '{"key": "value"}']],
+        ]);
+        expect(redis.data.get(`stream:stream:${id}`)).toEqual({
+          polled: false,
+        });
       });
   });