Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): install Jest dependencies via TypeScript and Node #5928

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

christian-bromann
Copy link
Member

What is the current behavior?

We use a bash script to install Jest dependencies which unfortunately is not possible to run in Windows without additional setup.

What is the new behavior?

Replace the shell script with a TypeScript file which makes running it much easier as no additional setup is needed.

Documentation

n/a

Does this introduce a breaking change?

  • Yes
  • No

Testing

Tested this manually and it works as expected.

Other information

n/a

@christian-bromann christian-bromann requested a review from a team as a code owner August 5, 2024 23:16
@christian-bromann christian-bromann requested review from gnbm and tanner-reits and removed request for a team August 5, 2024 23:16
Copy link
Contributor

github-actions bot commented Aug 5, 2024

@stencil/core@4.20.0 ts
tsc --noEmit --project scripts/tsconfig.json && tsx scripts/tech-debt-burndown-report.ts

--strictNullChecks error report

Typechecking with --strictNullChecks resulted in 1071 errors on this branch.

That's the same number of errors on main, so at least we're not creating new ones!

reports and statistics

Our most error-prone files
Path Error Count
src/dev-server/index.ts 37
src/dev-server/server-process.ts 32
src/compiler/prerender/prerender-main.ts 22
src/runtime/vdom/vdom-render.ts 22
src/runtime/client-hydrate.ts 20
src/runtime/vdom/test/patch.spec.ts 19
src/runtime/vdom/test/util.spec.ts 19
src/screenshot/connector-base.ts 19
src/testing/puppeteer/puppeteer-element.ts 19
src/dev-server/request-handler.ts 15
src/compiler/prerender/prerender-optimize.ts 14
src/compiler/sys/stencil-sys.ts 14
src/runtime/connected-callback.ts 14
src/sys/node/node-sys.ts 14
src/compiler/prerender/prerender-queue.ts 13
src/compiler/sys/in-memory-fs.ts 13
src/runtime/set-value.ts 13
src/compiler/output-targets/output-www.ts 12
src/compiler/transformers/test/parse-vdom.spec.ts 12
src/compiler/transformers/transform-utils.ts 12
Our most common errors
Typescript Error Code Count
TS2322 338
TS2345 326
TS18048 190
TS18047 99
TS2722 27
TS2532 19
TS2531 19
TS2790 11
TS2454 10
TS2352 9
TS2769 8
TS2416 7
TS2538 4
TS18046 2
TS2684 1
TS2430 1

Unused exports report

There are 15 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports
File Line Identifier
src/runtime/bootstrap-lazy.ts 21 setNonce
src/screenshot/screenshot-fs.ts 18 readScreenshotData
src/testing/testing-utils.ts 198 withSilentWarn
src/utils/index.ts 145 CUSTOM
src/utils/index.ts 245 NODE_TYPES
src/utils/index.ts 269 normalize
src/utils/index.ts 7 escapeRegExpSpecialCharacters
src/compiler/app-core/app-data.ts 25 BUILD
src/compiler/app-core/app-data.ts 116 Env
src/compiler/app-core/app-data.ts 118 NAMESPACE
src/compiler/fs-watch/fs-watch-rebuild.ts 123 updateCacheFromRebuild
src/compiler/types/validate-primary-package-output-target.ts 82 satisfies
src/compiler/types/validate-primary-package-output-target.ts 82 Record
src/testing/puppeteer/puppeteer-declarations.ts 496 WaitForEventOptions
src/compiler/sys/fetch/write-fetch-success.ts 7 writeFetchSuccessSync

Copy link
Contributor

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine, but got some broken CI

@christian-bromann
Copy link
Member Author

Changes seem fine, but got some broken CI

Yep, these are the same errors I got in #5899 which this PR is based on. I change the PR target to main.

@christian-bromann christian-bromann force-pushed the cb/install-dependencies-in-ts branch from ce2f097 to ba62f84 Compare August 6, 2024 18:36
@christian-bromann christian-bromann changed the base branch from cb/copy-task-ignore to main August 6, 2024 18:36
@christian-bromann christian-bromann added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit 70c4e8a Aug 8, 2024
92 checks passed
@christian-bromann christian-bromann deleted the cb/install-dependencies-in-ts branch August 8, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants