Modal animation #706
Open
Modal animation #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is a draft and should not be merged !
I have attempted to add animation to the modals on open and close.
It turned out to be more complicated than imagined.
I have succeeded in animating open, but not the closing of the modals. Probably because the parents handle (open/) closing of their respective modals.
Looking deeper into it, I tried moving all the modal handling to _app.tsx to control it globally, but couldn't get it to work.
I think this is the best approach to pursue.
Further explanation - #709
It would be great if someone else can take over the task