Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates #702

Merged
merged 5 commits into from
Feb 20, 2025
Merged

Minor updates #702

merged 5 commits into from
Feb 20, 2025

Conversation

babalicious-io
Copy link
Collaborator

Stamping Tool

  • changed CPID input field to max 21 characters (kept max 13 chars for POSH)

Fee Selector

  • updated styling of ToS
  • updated the fee slider selector to accept 0.5 sats incremental steps between 0 and 10 and 1 sats above 10 (as before)
  • we can change the steps to 0.25 or anything else - if desired
  • first 1/3 of the slider defines steps between 0 and 10, last 2/3 toggles steps above 10 (this should give the user better control when selecting the fee rate, instead of the original linear slider approach)
  • readded the live update feature (it was commented out) - the "Estimate" and "Details" price value update in the stamping tool lags a little and creates update glitches. This needs to be addressed (faster fetch or maybe just liveupdate the "Fee" value). The other pages and modales look/work fine.

@babalicious-io
Copy link
Collaborator Author

Screenshot 2025-02-18 at 21 55 14
Screenshot 2025-02-18 at 21 55 30

There is something off with the "Total" value

@babalicious-io
Copy link
Collaborator Author

There is something off with the "Total" value

From Claude:
The stamping tool (OlgaContent) currently calculates the total value by manually adding minerFee to total_output_value, while other components (Deploy/Mint/Transfer) use the total_output_value directly from their respective API responses. This inconsistency leads to incorrect total values being displayed in the stamping tool. The fix is simple: use total_output_value directly without additional calculations, matching the pattern used across other components. The code for this is already present but commented out in OlgaContent.tsx. Recommend uncommenting the direct total_output_value usage and removing the manual calculation to ensure consistent behavior across all tools.

@babalicious-io
Copy link
Collaborator Author

I have updated the missing button text in DeployContent.tsx
Please check line 466 - dunno if that is correct

@reinamora137 reinamora137 merged commit 01b6ef1 into dev Feb 20, 2025
2 checks passed
@reinamora137 reinamora137 deleted the baba/minor_updates_77 branch February 20, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants