Tidy Result/Option use #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Semantics aren't *identical*, since this adds vertical tab to the filter.
This saves an allocation of the empty string in the no-Content-Transfer-Encoding case.
staktrace
reviewed
Sep 7, 2018
There was a problem hiding this comment.
Do you know how this (edit: referring to try_none! replacement) works? It seems to me that assumes Option implements std::ops::Try but according to the docs that's only the case on the Nightly channel. And yet these patches are passing CI which builds on beta and release rust as well.
|
It was added in 1.22.0:
|
|
Ok, great! |
|
Thanks for the patches and particularly for keeping each change in a separate patch, it makes it nice and easy to review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes use of
try!andtry_none!, amongst various other cleanups.7eda2c0 slightly changes base64 handling: vertical tabs weren't getting stripped. I think this is reasonable.