With kubernetes/eks 1.30 or higher and sleep lifecycle the controller not restart deployment #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuneebAijaz
previously approved these changes
Nov 20, 2024
|
@mlophez can you address the failing lints in the build? |
karl-johan-grahn
approved these changes
Dec 4, 2024
|
@karl-johan-grahn Is there a release underway or can we request one, as we are waiting on this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #754
When using Kubernetes 1.30 or higher, the Deployment object adds new lifecycle policies, such as sleeplifecycle.
https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/
When you add this, the controller throws the following error and not restart deployment:
This happens because, in the current project libraries, the Deployment object does not have those properties.
When we updated the project's libraries to version 1.31, the problem was resolved.
´´´
go get k8s.io/api@v0.31.1
go get k8s.io/apimachinery@v0.31.1
go get k8s.io/client-go@v0.31.1
go get k8s.io/kubectl@v0.31.1
´´´
Only i update kubernetes library to minimize impact.