Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign curve fitting dialog #572

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Conversation

sstendahl
Copy link
Owner

@sstendahl sstendahl commented Nov 14, 2023

Redesigns the curve fitting dialog, addresses the points in the GNOME Circle feedback, and makes the dialog more responsive for different screen sizes.

Before:
image

After:
image

@cmkohnen
Copy link
Collaborator

The "Graphs (Development)" Title on this feels off.
Also since this is kind of a modal dialog, I don't know if this style of sidebar would fit like it does in the main application

@sstendahl
Copy link
Owner Author

sstendahl commented Nov 15, 2023

The "Graphs" title on the left probably feels better for a stable build, so without the "(Development)" part. But I think I agree with you that the Splitview look is probably a bit weird with a modal window. It kinda feels like a second application that's stuck to the main window, instead of it being a modal dialog.

The other issue, that did annoy me somewhat, is that the Action buttons simply clash with this design. If you resize the window the cancel button will be in the sidebar. So in compact mode only the graph is shown. To then dismiss the window, you have to expand the sidebar first to reveal the cancel button. It just feels off. Adding the cancel button to the content view in compact mode works but doesn't feel ideal either. So if we'd go with a Splitview, we'd probably have to change the controlls a bit.

I updated it to be more in line with regular modal windows, so closer to the orginal. See screenshot:

image

@sstendahl
Copy link
Owner Author

sstendahl commented Nov 15, 2023

Made some more tweaks, this now also disables interaction with the curve fitting window graph and adds the labels back to the graph.

image

@sstendahl sstendahl force-pushed the Redesign-curve-fitting-dialog branch from e218074 to 8364e7c Compare November 15, 2023 11:25
@sstendahl sstendahl merged commit cb2e0ad into main Nov 15, 2023
5 checks passed
@sstendahl
Copy link
Owner Author

For reference, here's with the updated figure style:

image

image

@sstendahl sstendahl deleted the Redesign-curve-fitting-dialog branch November 15, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants