-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign curve fitting dialog #572
Conversation
The "Graphs (Development)" Title on this feels off. |
The "Graphs" title on the left probably feels better for a stable build, so without the "(Development)" part. But I think I agree with you that the Splitview look is probably a bit weird with a modal window. It kinda feels like a second application that's stuck to the main window, instead of it being a modal dialog. The other issue, that did annoy me somewhat, is that the Action buttons simply clash with this design. If you resize the window the cancel button will be in the sidebar. So in compact mode only the graph is shown. To then dismiss the window, you have to expand the sidebar first to reveal the cancel button. It just feels off. Adding the cancel button to the content view in compact mode works but doesn't feel ideal either. So if we'd go with a Splitview, we'd probably have to change the controlls a bit. I updated it to be more in line with regular modal windows, so closer to the orginal. See screenshot: |
Linting
e218074
to
8364e7c
Compare
Redesigns the curve fitting dialog, addresses the points in the GNOME Circle feedback, and makes the dialog more responsive for different screen sizes.
Before:
After: