rework resetting item properties on style change #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Matthias Kohnen <christoph.kohnen@disroot.org>
Signed-off-by: Christoph Matthias Kohnen <christoph.kohnen@disroot.org>
Signed-off-by: Christoph Matthias Kohnen <christoph.kohnen@disroot.org>
sstendahl
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #563, remove the preference option in regards to item override.
For visual reasons this also removes the grouping in the preferences, as there are only three items now.
Creating items has also been made more modular using some of the logic necessary to handle reset() properly.
Also revert usage of
__gtype_name__to check for instances of Item. This allows to have future items that inherit from e. g. DataItem.