PR: Add new API methods to the IPython console #18544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
commented
Jul 4, 2022
dalthviz
previously approved these changes
Jul 5, 2022
steff456
suggested changes
Jul 5, 2022
There was a problem hiding this comment.
thanks @ccordoba12 for this work, I left a couple of comments of style
dalthviz
reviewed
Jul 5, 2022
dalthviz
reviewed
Jul 5, 2022
ccordoba12
force-pushed
the
ipyconsole-api
branch
from
cd689c0 to
81f25b5
Compare
ccordoba12
force-pushed
the
ipyconsole-api
branch
from
81f25b5 to
65c8d84
Compare
dalthviz
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
create_client_for_kernelandrename_client_tab) are necessary to finish the migration of Spyder-notebook to the new API (see PR: Migrate to the new Spyder 5 API spyder-notebook#369)Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12