PR: Check status when retrieving sessions before parsing reply #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having received the response from the server to our request to list all sessions, first check whether the status is ok and only if it is, parse the reply. Before, this was done in the opposite order. Update the test to ensure reply is not parsed if status is not ok.
jitseniesen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having received the response from the server to our request to list all sessions, first check whether the status is ok and only if it is, parse the reply. Before (in code added in PR #232), this was done in the opposite order.
Update the test to ensure reply is not parsed if status is not ok.
Fixes #317.