Merge pull request #825 from hazendaz/master

[ITs] Move source/target to use release instead
spotbugs · Jun 9, 2024 · 4cf298a · 4cf298a
2 parents 817babe + 032c606
commit 4cf298a
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 4 deletions.
diff --git a/src/it-tools/build-tools/pom.xml b/src/it-tools/build-tools/pom.xml
@@ -92,8 +92,7 @@
         <version>@compilerPluginVersion@</version>
         <configuration>
           <debug>false</debug>
-          <source>8</source>
-          <target>8</target>
+          <release>8</release>
           <excludes>
             <exclude>fakeAnnotations/**</exclude>
             <exclude>jsr305/**</exclude>

diff --git a/src/it/MFINDBUGS-145/pom.xml b/src/it/MFINDBUGS-145/pom.xml
@@ -38,9 +38,12 @@
   <url>http://maven.apache.org</url>
 
   <properties>
+    <!-- These two are used due to old compiler on maven 3.6.3 GHA build -->
     <maven.compiler.source>8</maven.compiler.source>
     <maven.compiler.target>8</maven.compiler.target>
 
+    <maven.compiler.release>8</maven.compiler.release>
+
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
   </properties>

diff --git a/src/it/check-no-missing-classes/pom.xml b/src/it/check-no-missing-classes/pom.xml
@@ -36,8 +36,11 @@
   <name>check-no-missing-classes</name>
 
   <properties>
+    <!-- These two are used due to old compiler on maven 3.6.3 GHA build -->
     <maven.compiler.source>8</maven.compiler.source>
     <maven.compiler.target>8</maven.compiler.target>
+
+    <maven.compiler.release>8</maven.compiler.release>
   </properties>
 
   <dependencies>

diff --git a/src/it/common.xml b/src/it/common.xml
@@ -146,8 +146,7 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <configuration>
           <debug>false</debug>
-          <source>8</source>
-          <target>8</target>
+          <release>8</release>
           <excludes>
             <exclude>*fakeAnnotations/**</exclude>
             <exclude>jsr305/**</exclude>

diff --git a/src/it/skipEmpty/pom.xml b/src/it/skipEmpty/pom.xml
@@ -36,8 +36,11 @@
   <name>skipEmpty</name>
 
   <properties>
+    <!-- These two are used due to old compiler on maven 3.6.3 GHA build -->
     <maven.compiler.source>8</maven.compiler.source>
     <maven.compiler.target>8</maven.compiler.target>
+
+    <maven.compiler.release>8</maven.compiler.release>
   </properties>
 
   <build>