Skip to content

Commit

Permalink
Publish spotDL 4.2.11 (#2277)
Browse files Browse the repository at this point in the history
Fix flac scanning when no album art present #2238 @joeyballentine
Fix m3u file creation, with correct metadata generation #2258
@Silverarmor

Various documentation changes & updates @Silverarmor 

Bump yt-dlp to 2025.1.15 to attempt to alleviate 403 Forbidden errors.
  • Loading branch information
Silverarmor authored Jan 16, 2025
2 parents 34f867c + 8273124 commit 5b1fd06
Show file tree
Hide file tree
Showing 19 changed files with 804 additions and 788 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/standard-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Run Pylint check
run: |
poetry run pylint --fail-under 10 --limit-inference-results 0 --disable=R0917,W0511 ./spotdl
poetry run pylint --fail-under 10 --limit-inference-results 0 --disable=R0917 ./spotdl
- name: Run MyPy check
run: |
Expand Down
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,3 @@ temp/
# VS Code
.vscode
*.txt

# Output Folder
output/
11 changes: 3 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ For a list of all **options** use ```spotdl -h```
`spotdl sync {filename}.spotdl`

- `meta`: Updates metadata for the provided song files.

</details>

## Music Sourcing and Audio Quality
Expand All @@ -149,19 +150,13 @@ Check the [Audio Formats](docs/usage.md#audio-formats-and-quality) page for more
Interested in contributing? Check out our [CONTRIBUTING.md](docs/CONTRIBUTING.md) to find
resources around contributing along with a guide on how to set up a development environment.

#### Join our amazing community as a code contributor, and help accelerate
### Join our amazing community as a code contributor, and help accelerate

<br><br>
<a href="/~https://github.com/spotDL/spotify-downloader/graphs/contributors">
<img class="dark-light" src="https://contrib.rocks/image?repo=spotDL/spotify-downloader&anon=0&columns=25&max=100&r=true" />
</a>
## Donate

help support the development and maintenance of the software ❤️

[![paypal](https://img.shields.io/badge/paypal-%2300457C.svg?&style=for-the-badge&logo=paypal&logoColor=white)](https://paypal.me/kko7)
[![kofi](https://img.shields.io/badge/kofi-%23F16061.svg?&style=for-the-badge&logo=ko-fi&logoColor=white)](https://ko-fi.com/xnetcat)

## License

This project is Licensed under the [MIT](/LICENSE) License.

14 changes: 7 additions & 7 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ everyone involved. The community looks forward to your contributions. 🎉
- [I Want To Contribute](#i-want-to-contribute)
- [Reporting Bugs](#reporting-bugs)
- [Suggesting Enhancements](#suggesting-enhancements)
- [Linting, Formatting and Type-checking](#Linting,-Formatting-and-Type-checking)
- [Python Documentation](#Python-Documentation)
- [Overview of the Project Structure](#Overview-of-the-Project-Structure)
- [Join The Project Team](#Join-The-Project-Team)
- [Linting, Formatting and Type-checking](#linting-formatting-and-type-checking)
- [Python Documentation](#python-documentation)
- [Overview of the Project Structure](#overview-of-the-project-structure)
- [Join The Project Team](#join-the-project-team)

## I Have a Question

Expand Down Expand Up @@ -108,7 +108,7 @@ potential bug as fast as possible.
#### How Do I Submit a Good Bug Report?

> You must never report security related issues, vulnerabilities or bugs to the issue tracker,
> or elsewhere in public. Instead sensitive bugs must be sent by discord to xnetcat#8144.
> or elsewhere in public. Instead sensitive bugs must be sent by Discord to Silverarmor (spotDL Discord Owner).
<!-- You may add a PGP key to allow the messages to be sent encrypted as well. -->

Expand All @@ -132,7 +132,7 @@ Once it's filed:
addressed until they are reproduced.
- If the team is able to reproduce the issue, it will be marked `needs-fix`, as well as
possibly other tags (such as `critical`), and the issue will be left to be
[implemented by someone](#your-first-code-contribution).
implemented by someone.

<!-- You might want to create an issue template for bugs and errors that can be used as a guide and that defines the structure of the information to be included. If you do so, reference it here in the description. -->

Expand Down Expand Up @@ -216,7 +216,7 @@ All changes will now affect the poetry installation of the spotDL cli.
- We use [`pylint`](https://pypi.org/project/pylint/) for linting and expect a score above `9`

```bash
pylint --limit-inference-results 0 --fail-under 9 ./spotdl
pylint --fail-under 10 --limit-inference-results 0 --disable=R0917 ./spotdl
```

- We use [`black`](https://pypi.org/project/black/) for code formatting
Expand Down
13 changes: 3 additions & 10 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Refer to our [Installation Guide](https://spotdl.rtfd.io/en/latest/installation/
- On Termux
- `curl -L https://raw.githubusercontent.com/spotDL/spotify-downloader/master/scripts/termux.sh | sh`
- Arch
- There is an [Arch User Repository (AUR) package](https://aur.archlinux.org/packages/python-spotdl/) for
- There is an [Arch User Repository (AUR) package](https://aur.archlinux.org/packages/spotdl/) for
spotDL.
- Docker
- Build image:
Expand Down Expand Up @@ -139,20 +139,13 @@ spotDL uses YouTube as a source for music downloads. This method is used to avoi
spotDL downloads music from YouTube and is designed to always download the highest possible bitrate; which is 128 kbps for regular users and 256 kbps for YouTube Music premium users.
Check the [Audio Formats](usage#audio-formats-and-quality) page for more info.
Check the [Audio Formats](usage.md#audio-formats-and-quality) page for more info.
## Contributing
Interested in contributing? Check out our [CONTRIBUTING.md](CONTRIBUTING) to find
Interested in contributing? Check out our [CONTRIBUTING.md](CONTRIBUTING.md) to find
resources around contributing along with a guide on how to set up a development environment.
## Donate
help support the development and maintenance of the software ❤️
[![paypal](https://img.shields.io/badge/paypal-%2300457C.svg?&style=for-the-badge&logo=paypal&logoColor=white)](https://paypal.me/kko7)
[![kofi](https://img.shields.io/badge/kofi-%23F16061.svg?&style=for-the-badge&logo=ko-fi&logoColor=white)](https://ko-fi.com/xnetcat)
## License
This project is Licensed under the [MIT](/LICENSE) License.
Expand Down
2 changes: 1 addition & 1 deletion docs/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ We have a dedicated Termux installation script

### Arch User Repository (AUR) package

[You can find the AUR Package here](https://aur.archlinux.org/packages/python-spotdl)
[You can find the AUR Package here](https://aur.archlinux.org/packages/spotdl)

## Where does spotDL download songs?

Expand Down
1 change: 0 additions & 1 deletion docs/usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,6 @@ If you don't want config to load automatically change `load_config` option in co
"scan_for_songs": false,
"m3u": null,
"output": "{artists} - {title}.{output-ext}",
"m3u_output": "#EXTINF:{duration}, {artists} - {title}.{output-ext}",
"overwrite": "skip",
"search_query": null,
"ffmpeg": "ffmpeg",
Expand Down
Loading

0 comments on commit 5b1fd06

Please sign in to comment.