feat: add Owned handle to flatbuffers to make passing around easier #2041
+228
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
commented
Jan 21, 2025
| Self: Sized; | ||
| } | ||
|
|
||
| macro_rules! make_owned { |
There was a problem hiding this comment.
this is a stripped-down macro inspired by https://docs.rs/flatbuffers-owned/latest/flatbuffers_owned/
a10y
force-pushed
the
aduffy/owned-fb
branch
2 times, most recently
from
1390e26 to
ed947ff
Compare
Due to the way flatbuffers creates all table types with attached lifetimes, we have to always pass around a buffer + loc to read a flatbuffer type. This PR adds some infra to make it easy to pass around `Owned` variants of all of our flatbuffer types, and feeds them into the IPC decoder and ArrayView constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way flatbuffers creates all table types with attached lifetimes, we have to always pass around a buffer + loc to read a flatbuffer type.
This PR adds some infra to make it easy to pass around
Ownedvariants of all of our flatbuffer types, and feeds them into the IPC decoder and ArrayView constructor