Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchor commitments 2024 #9264

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Anchor commitments 2024 #9264

merged 1 commit into from
Nov 26, 2024

Conversation

ecdsa
Copy link
Member

@ecdsa ecdsa commented Oct 20, 2024 •
edited
Loading

this was rebased in july 2024 from #7509
I guess it needs to be rebased again :-)

Here are my personal notes regarding this rebase:

  • some tests are broken (REDEEMED state reached too early in test_breach)
  • we should use password in memory (daemon unlock command)
  • if no password in memory (non-android GUI): maybe warn user?
  • stop LN support for watching-only and hardware wallets

@ecdsa ecdsa mentioned this pull request Oct 20, 2024
Closed
8 tasks
SomberNight
SomberNight reviewed Oct 20, 2024
View reviewed changes
@ecdsa ecdsa force-pushed the anchor_commitments_2024 branch 8 times, most recently from d95d10b to a4acc85 Compare November 26, 2024 08:44
@bitromortac @ecdsa
watchtower: only send first-stage HTLC justice txs
dbfc27d 
Due to malleability of HTLC-transactions, we can't send presigned
justice transactions for the second-stage HTLC transactions, which is
why we now send first-stage justice transactions for anchor channels.
@ecdsa ecdsa force-pushed the anchor_commitments_2024 branch from a4acc85 to dbfc27d Compare November 26, 2024 09:05
@ecdsa ecdsa marked this pull request as ready for review November 26, 2024 09:17
@ecdsa ecdsa merged commit dbfc27d into master Nov 26, 2024
13 of 16 checks passed
@ecdsa
Copy link
Member Author

ecdsa commented Nov 26, 2024 •
edited
Loading

Notes about this merge:

  • commits were merged individually (there is no merge commit).
  • anchor outputs can be activated by config variable enable_anchor_channels
  • unit tests are performed both with and without anchors. However, regtest are run only with anchors. (unlike in the original PR)
  • the commit that reorders functions in lnsweep was left out due to difficulty rebasing.
  • password-storing code was left out. Instead, htlc sweeping assumes that the wallet is unlocked, and calls wallet.get_unlocked_password()
  • a confusion between sats and msats was fixed (see FIXED_ANCHOR_SAT)
  • the for loop calling extract_preimage_from_htlc in f4ebe6e was left out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomberNight SomberNight SomberNight left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecdsa @SomberNight @bitromortac