-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXP: work with RankLineageInfo and sourmash tax #2603
base: latest
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #2603 +/- ##
==========================================
+ Coverage 85.27% 92.65% +7.38%
==========================================
Files 133 104 -29
Lines 15174 12435 -2739
Branches 2612 2398 -214
==========================================
- Hits 12939 11522 -1417
+ Misses 1934 609 -1325
- Partials 301 304 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 34 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
for easy reference:
Q from me as you're looking through the code - is there a recommended strategy for further abstracting |
Items for discussion:
|
I got interested in the refactoring of tuples of
LineagePair
that happened in #2437 and #2443 and thought I'd write some docs!See taxonomic-lineages-examples.md on this branch for the potential new docs page.
In the process, I found a few things that didn't make sense to me, so I tried filling them in. Specifically,
str
andrepr
forBaseLineageInfo
etc now showlineage_str
;lineage_str
is now filled in by the init code for all initializers;BaseLineageInfo
,RankLineageInfo
, andLINLineageInfo
no longer take positional arguments. This prevents certain kinds of bad things happening, likelin = RankLineageInfo(tuple_of_lineage_info)
from working and assigning tuples toranks
, for one not-so-hypothetical situation!TODO/to test;
lineage_str
being empty <=>RankLineageInfo(lineage_str='')
works.