feat: add object detection (android) #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmjkb
changed the title
chmjkb
force-pushed
the
@chmjkb/object-detection-android
branch
from
2b122ad to
4b93b7c
Compare
mkopcins
approved these changes
Dec 16, 2024
jakmro
force-pushed
the
@jakmro/classification-android
branch
from
c0e021e to
e653737
Compare
mkopcins
changed the base branch from
@jakmro/classification-android
to
main
chmjkb
force-pushed
the
@chmjkb/object-detection-android
branch
from
4b93b7c to
2c79aea
Compare
mkopcins
reviewed
Dec 17, 2024
Comment on lines
+60
to
+83
| {detections.map((detection, index) => { | ||
| const { scaleX, scaleY, offsetX, offsetY } = | ||
| calculateAdjustedDimensions(); | ||
| const { x1, y1, x2, y2 } = detection.bbox; | ||
|
|
||
| const left = x1 * scaleX + offsetX; | ||
| const top = y1 * scaleY + offsetY; | ||
| const width = (x2 - x1) * scaleX; | ||
| const height = (y2 - y1) * scaleY; | ||
|
|
||
| return ( | ||
| <View | ||
| key={index} | ||
| style={[ | ||
| styles.bbox, | ||
| { left, top, width, height, borderColor: 'red' }, | ||
| ]} | ||
| > | ||
| <Text style={styles.label}> | ||
| {detection.label} ({(detection.score * 100).toFixed(1)}%) | ||
| </Text> | ||
| </View> | ||
| ); | ||
| })} |
There was a problem hiding this comment.
In the future/in spare time would be nice to extract it into separete component (possibly in another file)
There was a problem hiding this comment.
I'll add a task for that :D
mkopcins
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes