Small improvements to style transfer #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove magic numbers
Make number self-explainable
Remove implicit cast
msluszniak
commented
Dec 9, 2024
Make functions concise
chmjkb
reviewed
Dec 10, 2024
Comment on lines
59
to
61
| NSNumber* numInputs = [module getNumberOfInputs]; | ||
| NSLog(@"RnExecutorch: %@", [module getNumberOfInputs]); | ||
| for (NSUInteger i = 0; i < [[module getNumberOfInputs] intValue]; i++) { |
There was a problem hiding this comment.
Can you also get rid of that for loops that only log stuff there? They don't seem necessary, thank you for contributing!:D
There was a problem hiding this comment.
Sure, I'm wondering if this PR is still needed as there is a PR with style transfer using OpenCV
Remove unused logging
msluszniak
commented
Dec 10, 2024
Remove unused variable
|
This is a very nice work with great attention to details. However I will close this PR, because those files were supposed to be changed from the start (perhaps shouldn't have been merged in the first place, they were only to ease further development). We can implement suggested changes in the refactored code for style transfer :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small improvements in readability of Style Transfer. Please double check it, as I haven't run the whole style transfer.