Add .cairo-coverage-ignore tests #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2024
ksew1
force-pushed
the
spr/main/f6098cdc
branch
from
542df8e to
9fcabb6
Compare
THenry14
reviewed
Dec 5, 2024
There was a problem hiding this comment.
it would be cool to also test the edge cases related to the /~https://github.com/software-mansion/cairo-coverage/pull/109/files (not necessarily e2e tests, could be just unit)
As an example:
- correct errors are thrown for CairoCoverageIgnoreMatcher::new (file does not exist?)
- does find_ignore_file really work for things up to root?
etc
ksew1
force-pushed
the
spr/main/9bc72f44
branch
from
f144fcc to
0618714
Compare
ksew1
added a commit
that referenced
this pull request
Dec 5, 2024
ksew1
force-pushed
the
spr/main/f6098cdc
branch
2 times, most recently
from
5845fe8 to
7e6f968
Compare
Really good idea 😄. Added this |
ksew1
force-pushed
the
spr/main/f6098cdc
branch
from
7e6f968 to
1b75b4b
Compare
5 tasks
ksew1
added a commit
that referenced
this pull request
Dec 9, 2024
<!-- Reference any GitHub issues resolved by this PR --> Related #110 (comment) ## Introduced changes <!-- A brief description of the changes --> - bump snforge in Scarb.toml and .tools-versions ## Checklist <!-- Make sure all of these are complete --> - [ ] Linked relevant issue - [ ] Updated relevant documentation - [ ] Added relevant tests - [x] Performed self-review of the code - [ ] Added changes to `CHANGELOG.md`
ksew1
added a commit
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
StatementCategoryFilterto separate module #108