Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): added Python support for sys_platform [PEP-508] #5675

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(python): added Python support for sys_platform [PEP-508] #5675

wants to merge 1 commit into from
+8 −8

Conversation

DOlufemi
Copy link
Contributor

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

Update snyk-python-plugin in order to support sys_platform as specified in PEP508

Where should the reviewer start?

How should this be manually tested?

  • Test by scanning a `requirements.txt file with a dependacies like this or similar
six==1.16.0 ; sys_platform == 'darwin' or sys_platform == 'linux'

@DOlufemi DOlufemi requested a review from a team as a code owner January 21, 2025 13:59
j-luong
j-luong requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@j-luong j-luong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: could we rename the PR title to something more descriptive of the change? It will be used for the release notes for the next release, so the change should be clear.

suggestion: feat(python): added Python support for sys_platform

@DOlufemi DOlufemi force-pushed the feat/pep-508-sys-platform branch from 32edfe8 to 0642e92 Compare January 23, 2025 10:40
@j-luong j-luong changed the title feat: upgrade snyk-python-plugin feat(python): added Python support for sys_platform [PEP-508] Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-luong j-luong j-luong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DOlufemi @j-luong