fix: fixed string for constraints - see issue #58 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this fix is kind of trivial, maybe it could be merged without adding a test? |
|
@johanneskoester I don't think we make any progress in extending the CI test cluster to support tests for constraints. Do you? Else: What do you think, can this be merged? |
|
Sorry, it took so long - been terribly busy, then holidays, no one else merged. I am hoping to find more co-developers willing to review. |
cmeesters
pushed a commit
that referenced
this pull request
Aug 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.9.0](v0.8.0...v0.9.0) (2024-08-06) ### Features * multicluster ([#56](#56)) ([c0f8fee](c0f8fee)) ### Bug Fixes * fixed string for constraints - see issue [#58](#58) ([#64](#64)) ([89e10ff](89e10ff)) --- This PR was generated with [Release Please](/~https://github.com/googleapis/release-please). See [documentation](/~https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no test - yet. I am not sure how to test constraints in the dummy SLURM setup of the CI.