make class inclusion check truthy to match snabbdom. fixes #59 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this is technically a breaking change, because it will change the html string output of any existing code that is passing "truthy" class values. We'll want to bump the major version when publishing this to npm. While we're bumping the major version, we may want to lump in an upgrade to the newest snabbdom while we're at it (3.x is the latest.) I'm happy to send another PR for that upgrade if that's something we're into. |
|
@acstll any thoughts/objections on this one? |
|
hey @mreinstein yes to all, please send the snabbdom update PR after that we can do a mejor version publish thank you very much! |
|
#62 should take care of this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.