Fixes for lwAFTR in many-worker configurations #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each configured queue, add a stats counter rxdrop_<queue_id> that reflects the hardware per-queue drop counter where <queue_id> is the queue id in the ConnectX configuration as defined by the user. # Conflicts: # src/apps/mellanox/connectx.lua
# Conflicts: # src/apps/mellanox/connectx.lua
…ling Rename cxq.next_rx_cqeid to cxq.rx_cqcc (completion queue consumer counter) and expand to 32 bit. This counter is not wrapped around the size of the cq. It is used to calculate the value of the SW ownership bit directly with efficient bitops and eliminates the need for the rx_mine member of cxq. # Conflicts: # src/apps/mellanox/connectx.lua
The event queue is polled at the frequency of sync_timer(). The
following events are supported:
* CQError. Prints the CQ number and syndrome, then aborts.
* PortStateChange. Prints the port number and new state
(up/down). This could be used to replace the get_port_status()
call in sync_stats()
* PageRequest. Allocates/deallocates the requested number of pages.
This works around an issue in lwaftr where workers hang on NUMA migrations. Possibly, this only fixes the issue on flat NUMA systems. See 89c48fc
Currenty, we create HCAs per stats request, and create indepedent stats requests for each per-queue counter set. HCAs are a limited resource, and many-queue configurations might run out of HCAs. As a workaround, allow counter set creation to be disabled per-queue.
- larger send/receive queues - force flow controll off - limit per-queue counters to not exceed HCA capacity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1473