Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use InsecureSkipVerify for validation #557

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

joejulian
Copy link
Contributor

Description

The server will not yet have a valid certificate so we need to disable
certificate validation in the HTTPGetter.

Fixes #554

The server will not yet have a valid certificate so we need to disable
certificate validation in the HTTPGetter.
@CLAassistant
Copy link

CLAassistant commented Apr 27, 2021

CLA assistant check
All committers have signed the CLA.

@maraino maraino requested a review from dopey April 27, 2021 17:50
@maraino
Copy link
Contributor

maraino commented Apr 27, 2021

@dopey @joejulian See my comment in #554 (comment)

@codecov-commenter
Copy link

Codecov Report

Merging #557 (6369a33) into master (582d6b1) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 6369a33 differs from pull request most recent head 0369151. Consider uploading reports for the commit 0369151 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
- Coverage   76.96%   76.92%   -0.04%     
==========================================
  Files         109      109              
  Lines        9773     9778       +5     
==========================================
  Hits         7522     7522              
- Misses       1868     1873       +5     
  Partials      383      383              
Impacted Files Coverage Δ
acme/api/handler.go 67.71% <0.00%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582d6b1...0369151. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http-01 (rfc 8555 8.3) redirects to https fail validation as the certificate is invalid
4 participants