Fix OpenAPI 3.0 output of nullable references #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #2151 to be merged to rebase this. |
When a nullable field or parameter references a non-nullable schema, we generate a schema for the field which uses anyOf to permit null. Any informational properties or additional assertions defined on the field are also put on the field schema and the type property is also retained. When we were transforming this field schema for OpenAPI 3.0, we were only doing certain transformations if the type property is not present, which doesn't handle the case above. Ensure the transformation to and from OpenAPI 3.0 schemas handles these nullable references which include the type property.
Azquelt
force-pushed
the
schema-nullable-ref-3.0
branch
from
49f0e4c to
9e8d58e
Compare
|
|
This has been rebased and is ready for review. |
MikeEdgar
approved these changes
Jan 15, 2025
|
Looks good, thanks @Azquelt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a nullable field or parameter references a non-nullable schema, we generate a schema for the field which uses anyOf to permit null. Any informational properties or additional assertions defined on the field are also put on the field schema and the type property is also retained.
When we were transforming this field schema for OpenAPI 3.0, we were only doing certain transformations if the type property is not present, which doesn't handle the case above.
Ensure the transformation to and from OpenAPI 3.0 schemas handles these nullable references which include the type property.
Fixes #2145