Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message on mapping generation failure #1175

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Improve message on mapping generation failure #1175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion implementation/src/main/java/io/smallrye/config/ConfigMappingContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ public StringBuilder getNameBuilder() {

@SuppressWarnings("unused")
public void reportProblem(RuntimeException problem) {
problem.printStackTrace();
problems.add(new Problem(problem.toString()));
}

Expand Down
6 changes: 5 additions & 1 deletion implementation/src/main/java/io/smallrye/config/ConfigMappingInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,11 @@ List<ConfigMappingInterface> getNested() {
}

public byte[] getClassBytes() {
return ConfigMappingGenerator.generate(this);
try {
return ConfigMappingGenerator.generate(this);
} catch (Throwable e) {
throw ConfigMessages.msg.couldNotGenerateMapping(e);
}
}

public static abstract class Property {
Expand Down
3 changes: 3 additions & 0 deletions implementation/src/main/java/io/smallrye/config/_private/ConfigMessages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,4 +169,7 @@ IllegalArgumentException converterException(@Cause Throwable converterException,

@Message(id = 50, value = "%s in %s does not map to any root")
IllegalStateException propertyDoesNotMapToAnyRoot(String name, String location);

@Message(id = 51, value = "Could not generate ConfigMapping")
IllegalStateException couldNotGenerateMapping(@Cause Throwable throwable);
}