Slim 4 support and PSR-15 #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0gicgate
requested changes
Sep 6, 2019
| "slim/slim": "~3.0", | ||
| "phpunit/phpunit": "^4.0" | ||
| "phpunit/phpunit": "^7.5", | ||
| "slim/psr7": "^0.5.0" |
There was a problem hiding this comment.
We don't need Slim/psr7 as a dependency. We can use prophecies to write the unit tests.
| */ | ||
| public function setUp() | ||
| public function setUp(): void |
There was a problem hiding this comment.
As mentioned in my previous comment, we should use prophecies instead of using an actual implementation to test. I can rewrite the tests for this if you're not quite familiar with that.
There was a problem hiding this comment.
If you can, yes, I prefer if you rewrite the tests 😄.
1 task
|
Follow in #105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Slim 4 and PSR-15 (implements MiddlewareInterface).
Also updated composer.json to fit our needs (Slim 4 and PHP set to ^7.1)
Added type-hinting and PHPUnit tests.
I'm using slim/psr7 for tests, but only AppFactory::determineResponseFactory() in source code to let users keep their own providers.
Resolve #102