ReferencedNameHelper: methods returning reference should not be consi…

…dered as a referenced name
slevomat · Jan 8, 2018 · 5309879 · 5309879
1 parent 604f322
commit 5309879
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/SlevomatCodingStandard/Helpers/ReferencedNameHelper.php b/SlevomatCodingStandard/Helpers/ReferencedNameHelper.php
@@ -196,6 +196,8 @@ private static function isReferencedName(\PHP_CodeSniffer\Files\File $phpcsFile,
 			return false;
 		} elseif ($previousToken['code'] === T_COMMA && TokenHelper::findPreviousLocal($phpcsFile, [T_CONST], $previousPointer - 1) !== null) {
 			return false;
+		} elseif ($previousToken['code'] === T_BITWISE_AND && TokenHelper::findPreviousLocal($phpcsFile, [T_FUNCTION], $previousPointer - 1) !== null) {
+			return false;
 		}
 
 		$isProbablyReferencedName = !in_array(

diff --git a/tests/Helpers/ReferencedNameHelperTest.php b/tests/Helpers/ReferencedNameHelperTest.php
@@ -137,4 +137,13 @@ public function testConstantIsNotReferencedName(): void
 		$this->assertCount(0, $names);
 	}
 
+	public function testMethodReturningReferenceIsNotReferencedName(): void
+	{
+		$codeSnifferFile = $this->getCodeSnifferFile(
+			__DIR__ . '/data/methodReturnsReference.php'
+		);
+		$names = ReferencedNameHelper::getAllReferencedNames($codeSnifferFile, 0);
+		$this->assertCount(0, $names);
+	}
+
 }
diff --git a/tests/Helpers/data/methodReturnsReference.php b/tests/Helpers/data/methodReturnsReference.php
@@ -0,0 +1,10 @@
+<?php
+
+class Foo
+{
+
+	public function & foo()
+	{
+	}
+
+}