Add supports for index type query and indexed access type #52
+76
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript 2.1 introduced index type query and indexed access type(i.e.
keyof
keyword). This pull request adds supports for it.📝 Example
TypeScript
Scala.js
✨ Convert strategy
Index Type Query
Index type query
keyof
should be converted string literal type.But it's converted to
string
type, because current Scala type system doesn't support literal type.Indexed Access Type
Indexed access type should be converted to its member type.
But it is hard to traverse object member at
Importer#typeToScala
without symbol table.I believe than inaccurate conversion is better than parse error, so I convert it to
any
type.🎉 Affects of this
keyof
is widely used at TypeScript definitions. For example, 662keyof
exists in DefinitelyTyped.It mainly used to express types of object key.