-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW Provide clear UX validation errors when violating unique index #11558
Merged
emteknetnz
merged 1 commit into
silverstripe:5
from
creative-commoners:pulls/5/unique-index-validation
Jan 15, 2025
Merged
NEW Provide clear UX validation errors when violating unique index #11558
emteknetnz
merged 1 commit into
silverstripe:5
from
creative-commoners:pulls/5/unique-index-validation
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/5/unique-index-validation
branch
from
January 15, 2025 01:32
e4794a7
to
e68f111
Compare
GuySartorelli
commented
Jan 15, 2025
GuySartorelli
commented
Jan 15, 2025
GuySartorelli
commented
Jan 15, 2025
GuySartorelli
commented
Jan 15, 2025
GuySartorelli
commented
Jan 15, 2025
GuySartorelli
commented
Jan 15, 2025
GuySartorelli
commented
Jan 15, 2025
GuySartorelli
commented
Jan 15, 2025
GuySartorelli
force-pushed
the
pulls/5/unique-index-validation
branch
from
January 15, 2025 02:22
e68f111
to
de3255c
Compare
GuySartorelli
force-pushed
the
pulls/5/unique-index-validation
branch
from
January 15, 2025 02:59
de3255c
to
ea864a4
Compare
GuySartorelli
commented
Jan 15, 2025
emteknetnz
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works well for SiteTree, DataObject, and content block in react context
GuySartorelli
force-pushed
the
pulls/5/unique-index-validation
branch
from
January 15, 2025 20:26
ea864a4
to
9f7d803
Compare
emteknetnz
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally with both MySQL and MariaDB
For an index with only a single column, it will show an error message next to the form field for that column:
For an index with multiple columns, it will show a single error message at the top of the edit form:
Issue