ENH Remove unused properties and deprecation notices #11543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@emteknetnz why did this one not get merged? There's no comments? |
emteknetnz
requested changes
Jan 13, 2025
| * | ||
| * @var bool | ||
| */ | ||
| private static $ignoreDeprecatedCaching = false; |
There was a problem hiding this comment.
Doesn't this need to be deprecated in CMS 5 first?
There was a problem hiding this comment.
It's not used but I guess technically it should be deprecated. Though nothing will actually change for people who are trying to use it - it does nothing now and it will continue to do nothing (with no error) in CMS 6.
|
Sorry didn't submit review |
GuySartorelli
force-pushed
the
pulls/6.0/deprecation-removal
branch
from
6eb1307 to
af02f10
Compare
GuySartorelli
force-pushed
the
pulls/6.0/deprecation-removal
branch
from
af02f10 to
10695ec
Compare
emteknetnz
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue