Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP PHP Support in CMS5 #33

Merged

Conversation

sabina-talipova
Copy link
Contributor

composer.json Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/3/upgrade-cms5 branch 3 times, most recently from 721562f to 2623dbf Compare December 21, 2022 19:49
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test failures

@sabina-talipova
Copy link
Contributor Author

sabina-talipova commented Jan 11, 2023

Reason for failed test is that composer installed dnadesign/silverstripe-elemental 5.0.0-alpha1.
/~https://github.com/silverstripe/silverstripe-elemental-fileblock/actions/runs/3753124017/jobs/6612598079#step:9:432
Passed tests in local.

@maxime-rainville
Copy link

I've created a alpha2 release for elemental to see if this fixes it.

Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prefer-lowest build is still failing because it still wants to install alpha1.

I'm going to call this a problem with the CI set up.

@maxime-rainville maxime-rainville merged commit e0d9877 into silverstripe:3 Jan 11, 2023
@maxime-rainville maxime-rainville deleted the pulls/3/upgrade-cms5 branch January 11, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants