fix: handle exceptions when using /0 as a URL #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Will. Since this is fixing a bug, it can target |
|
This is still an issue and has since carried over to the 5 branch of the CMS. |
GuySartorelli
force-pushed
the
wilr-patch-1
branch
from
eba3389 to
785676f
Compare
|
Rebased, added tests, and made changes necessary for those tests to pass. |
GuySartorelli
force-pushed
the
wilr-patch-1
branch
from
785676f to
fb95dd3
Compare
GuySartorelli
force-pushed
the
wilr-patch-1
branch
from
fb95dd3 to
fbc5470
Compare
michalkleiner
approved these changes
Nov 17, 2023
GuySartorelli
force-pushed
the
wilr-patch-1
branch
from
fbc5470 to
22e6dad
Compare
Comment on lines
458
to
+459
| $link = trim(Director::makeRelative($link) ?? '', '/'); | ||
| if (!$link) { | ||
| if ($link === false || $link === null || $link === '') { |
There was a problem hiding this comment.
Note that while trim() will only ever return a string, having the full check here avoids issues if we ever remove that trim.
emteknetnz
approved these changes
Nov 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2680