Improve database compaction and prune-states
#5142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
changed the title
prune-states
michaelsproul
added
ready-for-review
realbigsean
requested changes
Feb 7, 2024
realbigsean
added
waiting-on-author
realbigsean
added
ready-for-merge
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 6f442f2 |
5 tasks
danielrachi1
pushed a commit
to danielrachi1/lighthouse
that referenced
this pull request
Feb 14, 2024
* Fix no-op state prune check * Compact freezer DB after pruning * Refine DB compaction * Add blobs-db options to inspect/compact * Better key size * Fix compaction end key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
I noticed that
prune-statesdoesn't actually clear any space on disk because we don't compact the freezer database after running it.Proposed Changes
lighthouse db compactcommand for manually compacting specific columns in a specific DB (hot, freezer or blobs).--blobs-dboption tolighthouse db inspect(andcompact) so we can inspect the blobs DB as well as the freezer.Additional Info
I've manually tested the tree-states version of these changes (#5097) and the compaction works correctly.