Merge remote-tracking branch 'origin/master'

Signum.React/Scripts/Components/TextArea.tsx

@@ -23,12 +23,17 @@ export default function TextArea(p: TextAreaProps) {
   }, [innerRef, minHeight]);
 
   return (
-    <textarea onInput={autoResize ? (e => handleResize(e.currentTarget)) : undefined} style={
+    <textarea {...props} onInput={e => {
+      if (p.autoResize)
+        handleResize(e.currentTarget);
+      if (p.onInput)
+        p.onInput(e);
+    }} style={
       {
         ...(autoResize ? { display: "block", overflow: "hidden", resize: "none" } : {}),
         ...props.style
       }
-    } {...props} ref={handleRef} />
+    } ref={handleRef} />
   );
 }
 

Signum.React/Scripts/Frames/Notify.tsx

@@ -17,9 +17,10 @@ interface NotifyOptions {
 }
 
 interface NotifyHandle {
-  notify(options: NotifyOptions) : void;
-  notifyTimeout(options: NotifyOptions, timeout?: number): void
+  notify(options: NotifyOptions): NotifyOptions;
+  notifyTimeout(options: NotifyOptions, timeout?: number): NotifyOptions
   notifyPendingRequest(pending: number): void;
+  remove(options: NotifyOptions): void;
 }
 
 export default function Notify() {
@@ -39,12 +40,14 @@ export default function Notify() {
     optionsStack.current.extract(a => a == options);
     optionsStack.current.push(options);
     forceUpdate();
+    return options;
   }
 
-  function notifyTimeout(options: NotifyOptions, timeout: number = 2000) {
+  function notifyTimeout(options: NotifyOptions, timeout: number = 2000): NotifyOptions {
     notify(options);
 
     options.timeoutHandler = setTimeout(() => remove(options), timeout);
+    return options;
   }
 
   const loadingRef = React.useRef<NotifyOptions>({ text: JavascriptMessage.loading.niceToString(), type: "loading", priority: 0 });
@@ -69,7 +72,8 @@ export default function Notify() {
     Notify.singleton = {
       notify: notify,
       notifyTimeout: notifyTimeout,
-      notifyPendingRequest: notifyPendingRequest
+      notifyPendingRequest: notifyPendingRequest,
+      remove: remove,
     };
 
     return () => Notify.singleton = undefined;

Signum.React/Scripts/Globals.ts

@@ -819,8 +819,6 @@ String.prototype.tryAfterLast = function (this: string, separator: string) {
 String.prototype.etc = function (this: string, maxLength: number, etcString: string = "(…)") {
   let str = this;
 
-  str = str.tryBefore("\n") || str;
-
   if (str.length > maxLength)
     str = str.substr(0, maxLength - etcString.length) + etcString;
 

Signum.React/Scripts/Lines/AutoCompleteConfig.tsx

@@ -156,7 +156,8 @@ export class FindOptionsAutocompleteConfig implements AutocompleteConfig<ResultR
 
     var filters = [...fo.filterOptions ?? []];
 
-    if (fo.includeDefaultFilters ?? true) {
+    /*When overriden in Finder very often uses not seen columns (like Telephone) that are not seen in autocomplete, better to use false by default and you can opt-in by adding includeDefaultFilters if needed */
+    if (fo.includeDefaultFilters ?? false) { 
       var defaultFilters = Finder.getDefaultFilter(qd, qs);
       if (defaultFilters)
         filters = [...defaultFilters, ...filters];

Signum.React/Scripts/Operations/EntityOperations.tsx

@@ -129,7 +129,7 @@ export function andNew<T extends Entity>(eoc: EntityOperationContext<T>, inDropd
           Navigator.getSettings(pack.entity.Type)?.onCreateNew ??
           (pack => Constructor.constructPack(pack.entity.Type));
 
-        createNew(pack)
+        (createNew(pack) ?? Promise.resolve(undefined))
           .then(newPack => newPack && eoc.frame.onReload(newPack, true))
           .done();
       };

Signum.React/Scripts/SearchControl/EntityLink.tsx

@@ -26,16 +26,19 @@ export default function EntityLink(p: EntityLinkProps) {
       innerRef={p.innerRef as any}
       to={Navigator.navigateRoute(lite)}
       title={StyleContext.default.titleLabels ? p.title ?? getToString(lite) : undefined}
-      onClick={handleClick}
       data-entity={liteKey(lite)}
-      {...(htmlAtts as React.HTMLAttributes<HTMLAnchorElement>)}>
+      {...(htmlAtts as React.HTMLAttributes<HTMLAnchorElement>)}
+      onClick={handleClick}
+    >
       {children ?? lite.toStr}
     </Link>
   );
 
   function handleClick(event: React.MouseEvent<any>) {
 
     event.preventDefault();
+    p.onClick?.call(event.currentTarget, event);
+
     const lite = p.lite;
     const s = Navigator.getSettings(lite.EntityType)
     const avoidPopup = s != undefined && s.avoidPopup;

Signum.React/Scripts/SearchControl/SearchControlLoaded.tsx

@@ -550,7 +550,7 @@ export default class SearchControlLoaded extends React.Component<SearchControlLo
         order: -5,
         button: <button
           className={classes("sf-query-button sf-filters-header btn", s.showFilters && "active", "btn-light")}
-          style={!s.showFilters && p.findOptions.filterOptions.filter(a => !a.pinned).length > 0 ? { border: "1px solid black" } : undefined}
+          style={!s.showFilters && p.findOptions.filterOptions.filter(a => !a.pinned).length > 0 ? { border: "1px solid #6c757d" } : undefined}
           onClick={this.handleToggleFilters}
           title={titleLabels ? s.showFilters ? JavascriptMessage.hideFilters.niceToString() : JavascriptMessage.showFilters.niceToString() : undefined}>
           <FontAwesomeIcon icon="filter" />

Signum.React/Scripts/Services.ts

@@ -5,6 +5,7 @@ export interface AjaxOptions {
   url: string;
   avoidNotifyPendingRequests?: boolean;
   avoidThrowError?: boolean;
+  avoidRetry?: boolean;
   avoidGraphExplorer?: boolean;
   avoidAuthToken?: boolean;
   avoidVersionCheck?: boolean;
@@ -103,6 +104,11 @@ export function wrapRequest(options: AjaxOptions, makeCall: () => Promise<Respon
     addContextHeaders.forEach(f => f(options));
   }
 
+  if (!options.avoidRetry) {
+    const call = makeCall;
+    makeCall = () => RetryFilter.retryFilter(call);
+  }
+
   if (!options.avoidVersionCheck) {
     const call = makeCall;
     makeCall = () => VersionFilter.onVersionFilter(call);
@@ -132,6 +138,12 @@ export function wrapRequest(options: AjaxOptions, makeCall: () => Promise<Respon
 
 }
 
+export module RetryFilter {
+  export function retryFilter(makeCall: () => Promise<Response>): Promise<Response>{
+    return makeCall();
+  }
+}
+
 export module AuthTokenFilter {
   export let addAuthToken: (options: AjaxOptions, makeCall: () => Promise<Response>) => Promise<Response>;
 }