Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.4.0 #24

Merged
merged 22 commits into from
Jan 8, 2025
Merged

0.4.0 #24

merged 22 commits into from
Jan 8, 2025

Conversation

salam99823
Copy link
Collaborator

@salam99823 salam99823 commented Jan 5, 2025

0.4.0 - 2025-01-06

Added

  • Module prelude which contains all public structs and modules
    (5be223b).
  • image dependency (e7fe636).
  • Structures
    (e792bbb):
    • AbstractCollidersBuilder
    • AbstractCollider

Changed

Removed

  • Modules
    (e792bbb):
    • avian2d
    • rapier2d
  • Functions
    (e792bbb):
    • generate_collider
    • generate_colliders
  • rayon from dependencies
    (e7fe636).

@salam99823 salam99823 added enhancement New feature or request help wanted Extra attention is needed labels Jan 5, 2025
@salam99823 salam99823 marked this pull request as draft January 5, 2025 13:39
@shnewto
Copy link
Owner

shnewto commented Jan 5, 2025

oh weird, yeah the boulders just hang there 🤔

@shnewto
Copy link
Owner

shnewto commented Jan 5, 2025

So using convex_polyline colliders where we were using polyline colliders seems to be a workaround but hah I think we should figure out why polyline colliders don't do what we're expecting or understand why they're doing what they're doing if that's expected behavior 🤔

@shnewto
Copy link
Owner

shnewto commented Jan 5, 2025

Oh from the rapier docs

It is discouraged to use a triangle meshes or a polylines for colliders attached to dynamic rigid-bodies.

https://rapier.rs/docs/user_guides/bevy_plugin/colliders

@shnewto
Copy link
Owner

shnewto commented Jan 5, 2025

Ah okay, I think if you're able to make the changes to use convex_polyline for the boulders we're good with these changes. I don't think the behavior is a regression because in the current main branch the boulders are already using convex polyline colliders and if you use simple polyline colliders there it's the same behavior.

@salam99823
Copy link
Collaborator Author

Thanks for helping me find the problem.

@salam99823 salam99823 force-pushed the dev branch 2 times, most recently from 88e11d6 to 04b3e7c Compare January 5, 2025 18:11
@salam99823 salam99823 removed the help wanted Extra attention is needed label Jan 5, 2025
@salam99823 salam99823 marked this pull request as ready for review January 8, 2025 17:08
@salam99823 salam99823 requested a review from shnewto January 8, 2025 17:11
@salam99823
Copy link
Collaborator Author

Looks like all the changes. Please do not delete dev branch.

Copy link
Owner

@shnewto shnewto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again @salam99823, thank you for the thoughtful work you put into your PRs and into this crate

@shnewto shnewto merged commit 41f6b03 into main Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants