feat: more robust default version selector injection location

shipgirlproject · Nov 3, 2024 · 98e961b · 98e961b
1 parent cf9ab17
commit 98e961b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/src/assets/versionsMenu.js b/src/assets/versionsMenu.js
@@ -19,8 +19,3 @@ select.onchange = () => {
 	const newUrl = new URL(newPaths, window.location.origin);
 	window.location.assign(newUrl);
 };
-
-const header = document.querySelector('header.tsd-page-toolbar #tsd-search');
-if (!!header && select.className.includes('title')) {
-	header.prepend(select);
-}
diff --git a/src/etc/hooks.tsx b/src/etc/hooks.tsx
@@ -55,12 +55,18 @@ export function injectSelectHtml(
 			<select id="plugin-versions-select" name="versions"></select>
 		));
 	} else {
-		app.renderer.hooks.on('body.begin', () => (
-			<select
-				id="plugin-versions-select"
-				class="title"
-				name="versions"
-			></select>
+		app.renderer.hooks.on('head.end', () => (
+			<style>{`
+				.tsd-ext-version-select .settings-label {
+					margin: 0.75rem 0.75rem 0 0;
+			`}</style>
+		));
+
+		app.renderer.hooks.on('pageSidebar.begin', () => (
+			<div class="tsd-ext-version-select">
+				<label class="settings-label" for="plugin-versions-select">Version</label>
+				<select id="plugin-versions-select" name="versions"></select>
+			</div>
 		));
 	}
 }