Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only include initial chunks #48

Merged
merged 2 commits into from
Jul 6, 2017
Merged

fix: Only include initial chunks #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a43a4e
opt.omitDlls: import() and require.ensure skipping
a-x- Jul 3, 2017
ca06108
update test
Jul 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 19 additions & 17 deletions lib/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,24 +42,26 @@ ManifestPlugin.prototype.apply = function(compiler) {
var stats = compilation.getStats().toJson();
var manifest = {};

_.merge(manifest, compilation.chunks.reduce(function(memo, chunk) {
var chunkName = chunk.name ? chunk.name.replace(this.opts.stripSrc, '') : null;

// Map original chunk name to output files.
// For nameless chunks, just map the files directly.
return chunk.files.reduce(function(memo, file) {
// Don't add hot updates to manifest
if (file.indexOf('hot-update') >= 0) {
_.merge(manifest, compilation.chunks
.filter(chunk => chunk.isInitial ? chunk.isInitial() : chunk.initial)
.reduce(function(memo, chunk) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like if we use (memo, chunk) => {...} we get the right context and we can skip .bind(this)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zuzusik You are right, but it can't happens before #53
I did the mistake of merging this PR without caring for older node versions
I added tests to prevent this kind of mistake in the future

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, got it

var chunkName = chunk.name ? chunk.name.replace(this.opts.stripSrc, '') : null;

// Map original chunk name to output files.
// For nameless chunks, just map the files directly.
return chunk.files.reduce(function(memo, file) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as /~https://github.com/danethurber/webpack-manifest-plugin/pull/48/files#r126661193, but will work only in combination with the previous (e.g. if both functions are arrow)

// Don't add hot updates to manifest
if (file.indexOf('hot-update') >= 0) {
return memo;
}
if (chunkName) {
memo[chunkName + '.' + this.getFileType(file)] = file;
} else {
memo[file] = file;
}
return memo;
}
if (chunkName) {
memo[chunkName + '.' + this.getFileType(file)] = file;
} else {
memo[file] = file;
}
return memo;
}.bind(this), memo);
}.bind(this), {}));
}.bind(this), memo);
}.bind(this), {}));

// module assets don't show up in assetsByChunkName.
// we're getting them this way;
Expand Down
2 changes: 1 addition & 1 deletion spec/plugin.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ describe('ManifestPlugin', function() {
output: { filename: '[name].[hash].js' }
}, function(manifest, stats) {
expect(manifest['nameless.js']).toEqual('nameless.'+ stats.hash +'.js');
expect(manifest['1.1.'+ stats.hash +'.js']).toEqual('1.1.'+ stats.hash +'.js');
expect(manifest['1.1.'+ stats.hash +'.js']).toEqual(undefined);
done();
});
});
Expand Down