Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bit_order attribute #468

Closed
wants to merge 1 commit into from
Closed

Conversation

wcampbell0x2a
Copy link
Collaborator

No description provided.

Copy link

Benchmark for 09e5363

Click to view benchmark
Test Base PR %
deku_read_bits 1167.8±15.75ns 1151.4±26.14ns -1.40%
deku_read_byte 3.3±0.18ns 3.3±0.07ns 0.00%
deku_read_enum 2.6±0.07ns 2.5±0.05ns -3.85%
deku_read_vec 33.4±0.17ns 33.5±0.23ns +0.30%
deku_write_bits 181.1±3.81ns 227.3±8.01ns +25.51%
deku_write_byte 22.8±0.48ns 21.5±0.39ns -5.70%
deku_write_enum 21.4±0.39ns 20.8±0.44ns -2.80%
deku_write_vec 398.9±6.73ns 292.9±7.52ns -26.57%

Copy link

Benchmark for 3ab739b

Click to view benchmark
Test Base PR %
deku_read_bits 1161.9±18.70ns 1206.1±48.70ns +3.80%
deku_read_byte 3.3±0.11ns 3.3±0.12ns 0.00%
deku_read_enum 2.6±0.06ns 2.5±0.05ns -3.85%
deku_read_vec 33.5±0.27ns 33.1±1.06ns -1.19%
deku_write_bits 183.1±7.66ns 213.5±4.10ns +16.60%
deku_write_byte 22.8±0.57ns 21.4±0.34ns -6.14%
deku_write_enum 21.4±0.21ns 20.8±0.34ns -2.80%
deku_write_vec 344.8±6.03ns 275.8±7.68ns -20.01%

@wcampbell0x2a wcampbell0x2a force-pushed the impl-reader-bit-order3 branch 2 times, most recently from b3a8778 to 3173155 Compare August 22, 2024 02:55
Copy link

Benchmark for 50a0120

Click to view benchmark
Test Base PR %
deku_read_bits 1185.5±15.62ns 1157.4±17.51ns -2.37%
deku_read_byte 3.3±0.08ns 3.3±0.07ns 0.00%
deku_read_enum 2.6±0.04ns 2.5±0.07ns -3.85%
deku_read_vec 33.3±0.34ns 33.4±0.46ns +0.30%
deku_write_bits 182.0±2.19ns 237.5±4.94ns +30.49%
deku_write_byte 22.8±0.73ns 21.4±0.28ns -6.14%
deku_write_enum 21.4±0.37ns 20.9±1.17ns -2.34%
deku_write_vec 403.1±9.18ns 306.2±4.50ns -24.04%

Copy link

Benchmark for 75650a7

Click to view benchmark
Test Base PR %
deku_read_bits 1163.4±15.10ns 1220.5±28.61ns +4.91%
deku_read_byte 3.3±0.07ns 3.3±0.06ns 0.00%
deku_read_enum 2.6±0.06ns 2.5±0.05ns -3.85%
deku_read_vec 33.8±0.34ns 32.9±0.50ns -2.66%
deku_write_bits 180.2±3.51ns 211.5±3.26ns +17.37%
deku_write_byte 22.7±0.32ns 21.4±0.41ns -5.73%
deku_write_enum 21.6±1.17ns 20.8±0.41ns -3.70%
deku_write_vec 379.6±4.16ns 283.1±3.85ns -25.42%

@wcampbell0x2a wcampbell0x2a force-pushed the impl-reader-bit-order3 branch from 3173155 to 813a123 Compare August 23, 2024 13:24
Copy link

Benchmark for e7b5011

Click to view benchmark
Test Base PR %
deku_read_bits 1165.9±17.89ns 1217.1±76.84ns +4.39%
deku_read_byte 3.3±0.08ns 3.3±0.13ns 0.00%
deku_read_enum 2.5±0.08ns 2.6±0.09ns +4.00%
deku_read_vec 33.0±1.01ns 33.9±0.24ns +2.73%
deku_write_bits 199.1±6.62ns 224.7±5.28ns +12.86%
deku_write_byte 22.7±0.37ns 21.7±0.30ns -4.41%
deku_write_enum 21.8±0.87ns 20.5±0.33ns -5.96%
deku_write_vec 435.6±5.68ns 277.6±4.88ns -36.27%

@sharksforarms
Copy link
Owner

@wcampbell0x2a is this ready for review / 0.18? I'll need to allocate some time to review this one

@wcampbell0x2a
Copy link
Collaborator Author

@wcampbell0x2a is this ready for review / 0.18? I'll need to allocate some time to review this one

Let's leave this off. I'll also need time to review and check all of these changes again.

@wcampbell0x2a wcampbell0x2a mentioned this pull request Sep 24, 2024
@wcampbell0x2a
Copy link
Collaborator Author

Closing, rebased with #483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants