Add check name to ArgumentError #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"sensu_check name invalid" needs more information about *which* check name is failing the ArgumentError.
|
@amccrea Thanks for the contribution! This will definitely help out debugging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Added "value" variable to output of ArgumentError message.
Description
Added "value" variable to output of ArgumentError message.
Related Issue
Motivation and Context
"sensu_check name invalid" needs more information about which check name is failing the ArgumentError. Otherwise it makes it hard to debug when you have thousands of checks.
How Has This Been Tested?
Edited code on our puppet server, pushed out, works great. Told me the name of the check which had accidentally gotten a space in the name during a giant sed.
General
Update
README.mdwith any necessary configuration snippets - No new info.New parameters are documented - no new parameters
New parameters have tests - no new parameters
Tests pass -
bundle exec rake validate lint spec- haven't tested this.