Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update archiver sha to fix git tarball bug #1980

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Conversation

nikkictl
Copy link

@nikkictl nikkictl commented Aug 16, 2018

Signed-off-by: Nikki Attea nikki@sensu.io

What is this change?

Updates the archiver dependency to fix a bug with extracting git tarballs.

Why is this change necessary?

Closes #1700

Does your change need a Changelog entry?

Yas.

Do you need clarification on anything?

Nah.

Were there any complications while making this change?

I had to open a pr to the dependency: mholt/archiver@85d3d0b

Have you reviewed and updated the documentation for this change? Is new documentation required?

sensu/sensu-docs#667

Signed-off-by: Nikki Attea <nikki@sensu.io>
Copy link
Contributor

@teekennedy teekennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@palourde palourde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikkictl nikkictl merged commit 74105cb into master Aug 16, 2018
@nikkictl nikkictl deleted the bugfix/asset-tarball branch August 16, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assets from git tarballs cannot be extracted
3 participants