-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback Pipeline addition in core/v2 #16
base: main
Are you sure you want to change the base?
Changes from 8 commits
ea4b418
11e3b42
e995dd3
5cd4bb8
0cc3d53
d3d2d32
4f5a02d
5b8ee99
8b73142
d8b5f44
dab253f
55991f8
14fccb0
b501a68
a7807cc
33d8d94
0a6be80
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,9 +168,13 @@ message CheckConfig { | |
// Pipelines are the pipelines this check will use to process its events. | ||
repeated ResourceReference pipelines = 32 [ (gogoproto.jsontag) = "pipelines" ]; | ||
|
||
repeated MetricThreshold output_metric_thresholds = 33 [ (gogoproto.jsontag) = "output_metric_thresholds,omitempty", (gogoproto.moretags) = "yaml: \"output_metric_thresholds,omitempty\"" ]; | ||
//added fallback pieplines detials in order of execution | ||
repeated ResourceReference fallback_pipeline = 33 [ (gogoproto.jsontag) = "fallback_pipeline" ,(gogoproto.moretags) = "yaml: \"fallback_pipeline,omitempty\"" ]; | ||
|
||
repeated TimeWindowRepeated subdues = 34 [ (gogoproto.jsontag) = "subdues,omitempty" ]; | ||
|
||
repeated MetricThreshold output_metric_thresholds = 34 [ (gogoproto.jsontag) = "output_metric_thresholds,omitempty", (gogoproto.moretags) = "yaml: \"output_metric_thresholds,omitempty\"" ]; | ||
|
||
repeated TimeWindowRepeated subdues = 35 [ (gogoproto.jsontag) = "subdues,omitempty" ]; | ||
} | ||
|
||
// A Check is a check specification and optionally the results of the check's | ||
|
@@ -328,11 +332,14 @@ message Check { | |
// Pipelines are the pipelines this check will use to process its events. | ||
repeated ResourceReference pipelines = 46 [ (gogoproto.jsontag) = "pipelines" ]; | ||
|
||
//fallback pieplines detials in order of execution | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typo: should be |
||
repeated ResourceReference fallback_pipeline = 47 [ (gogoproto.jsontag) = "fallback_pipeline" ,(gogoproto.moretags) = "yaml: \"fallback_pipeline,omitempty\"" ]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If there can be more than one this field should be plural (fallback_pipelines). |
||
|
||
// MetricThresholds are a list of thresholds to apply to metrics in order to determine | ||
// the check status. | ||
repeated MetricThreshold output_metric_thresholds = 47 [ (gogoproto.jsontag) = "output_metric_thresholds,omitempty", (gogoproto.moretags) = "yaml: \"output_metric_thresholds,omitempty\"" ]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment about field numbers. |
||
repeated MetricThreshold output_metric_thresholds = 48 [ (gogoproto.jsontag) = "output_metric_thresholds,omitempty", (gogoproto.moretags) = "yaml: \"output_metric_thresholds,omitempty\"" ]; | ||
|
||
repeated TimeWindowRepeated subdues = 48 [ (gogoproto.jsontag) = "subdues,omitempty" ]; | ||
repeated TimeWindowRepeated subdues = 49 [ (gogoproto.jsontag) = "subdues,omitempty" ]; | ||
|
||
// ExtendedAttributes store serialized arbitrary JSON-encoded data | ||
bytes ExtendedAttributes = 99 [ (gogoproto.jsontag) = "-" ]; | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we need to avoid changing field numbers since they're used for serialization/deserialization. We might end up with a scenario where the data was stored with field number
33
in etcd and read back with field number 34, effectively breaking serialization.