Added support for configure action #506
Conversation
|
Great @seesharper! Love this way of condiguring. ❤️ |
|
👍 I don't think we broke anything. Old constructors are still there. Or did I miss something? 😊 |
| /// <param name="options">The <see cref="ContainerOptions"/> instances that represents the configurable options.</param> | ||
| public ServiceContainer(ContainerOptions options) | ||
| /// <param name="configureOptions">A delegate used to configure <see cref="ContainerOptions"/>.</param> | ||
| public ServiceContainer(Action<ContainerOptions> configureOptions) |
There was a problem hiding this comment.
Is this adding or changing @seesharper? I am on my phone, so might miss something in this small view.
There was a problem hiding this comment.
Ah, I see how that might look like a breaking change. The constructor code was moved from ServiceContainer(ContainerOptions options) to ServiceContainer(Action<ContainerOptions> configureOptions)
The constructor with no parameters should create a ContainerOptions instance with the default values. It does so by calling into ServiceContainer(Action<ContainerOptions> configureOptions) with an "empty" configureOptionsdelegate so that the ContainerOptions instance created within ServiceContainer(Action<ContainerOptions> configureOptions) is left unchanged (default)"
This PR adds support for configuring the
ContainerOptionsusing a delegate.Requested by @haavamoa 😎