Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to PerLogicalCallContextScopeManagerProvider #450

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Sep 26, 2018

On target frameworks where it’s available, default to using PerLogicalCallContextScopeManagerProvider instead of PerThreadScopeManagerProvider.

See also #153.

On target frameworks where it’s available, default to using `PerLogicalCallContextScopeManagerProvider` instead of `PerThreadScopeManagerProvider`.

See also seesharper#153.
@seesharper
Copy link
Owner

@0xced Could you push an empty commit to trigger the branch build?

git commit --allow-empty -m "Trigger notification"

@0xced
Copy link
Contributor Author

0xced commented Sep 27, 2018

I just pushed it but it seems that the continuous-integration/appveyor/branch check does not trigger properly. 😕

@seesharper
Copy link
Owner

This is a part of AppVeyor that I don't understand. Why can't I see this build and restart it?

@0xced
Copy link
Contributor Author

0xced commented Sep 27, 2018

I tried to modify the appveyor.yml file as suggested in appveyor/ci#1115 (comment) but that didn't help. continuous-integration/appveyor/branch status is still Expected — Waiting for status to be reported

Maybe you have to configure AppVeyor for building only pull requests and not branches ?

@seesharper
Copy link
Owner

I'll take a look at it tonight. I'll merge manually if needed 👍

@seesharper seesharper merged commit f905236 into seesharper:master Sep 27, 2018
@0xced 0xced deleted the default_PerLogicalCallContextScopeManagerProvider branch September 27, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants