test needed assertion and also updated DummyClient

seek4science · Mar 3, 2025 · 55d45f7 · 55d45f7
1 parent f93777c
commit 55d45f7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/nels/rest/dummy_client.rb b/lib/nels/rest/dummy_client.rb
@@ -54,10 +54,10 @@ def sample_metadata(reference)
       def datasettypes
         JSON.parse '["MOCK_DATA","Microarray_Methylation_data","454_seq_data","AB_SOLiD_NGS_data","Track","test-lxx","fea","illumina-test-kp","xia-test-18-03","Illumina_seq_data","Sanger_seq_data","Molecular_Dynamics_data","Proteomics_data","Microarray_Gene_Expression_data","Illimuna seq data 2","hello","wei-test","xia-test-20-03"]'
       end      
-      def create_dataset(dataset)
+      def create_dataset(project_id, datasettype, name, description)
         ## TODO: start job to send data
       end
-      def upload_metadata(file)
+      def upload_metadata(project_id, dataset_id, subtype_name, file_path)
         ## TODO: start job to send data
       end
     end

diff --git a/test/functional/nels_controller_test.rb b/test/functional/nels_controller_test.rb
@@ -337,5 +337,6 @@ class NelsControllerTest < ActionController::TestCase
              params: { project: project_id, datasettype: datasettypeid, name: name, description: description }
       end
     end
+    assert_response :success
   end
 end
-Original file line number
+Diff line change
@@ Expand Up / @@ -337,5 +337,6 @@ class NelsControllerTest < ActionController::TestCase @@
                  params: { project: project_id, datasettype: datasettypeid, name: name, description: description }
           end
         end
+        assert_response :success
       end
     end