Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rsync): prefix sed with command #1338

Merged
merged 1 commit into from
Feb 25, 2025
Merged

refactor(rsync): prefix sed with command #1338

merged 1 commit into from
Feb 25, 2025

Conversation

yedayak
Copy link
Collaborator

@yedayak yedayak commented Feb 24, 2025

No description provided.

akinomyoga
akinomyoga approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the commit message and the PR title should be sed instead of cd. Otherwise, this is good. There do not seem to be other similar cases (which may be checked by running test/runLint. Note: we do not care about the test codes so much).

@akinomyoga
Copy link
Collaborator

We can consider breaking the line to fit it within 79 columns (ref styleguide).

@yedayak yedayak changed the title refactor(rsync): prefix cd with command refactor(rsync): prefix sed with command Feb 25, 2025
@scop scop merged commit 1b0ef83 into scop:main Feb 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinomyoga akinomyoga akinomyoga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yedayak @akinomyoga @scop